fix: report all golangci-lint issues regardless of diff#6622
Merged
Warashi merged 2 commits intopipe-cd:masterfrom Mar 28, 2026
Merged
fix: report all golangci-lint issues regardless of diff#6622Warashi merged 2 commits intopipe-cd:masterfrom
Warashi merged 2 commits intopipe-cd:masterfrom
Conversation
Set filter_mode to nofilter in reviewdog/action-golangci-lint so that gofmt issues on unchanged lines are not silently skipped during PR checks. Fixes pipe-cd#6621 Signed-off-by: majiayu000 <1835304752@qq.com>
Member
|
Thank you! |
Member
|
It's better if we can check on the PR what issue is raised, but it's nice to have, not mandatory. |
Contributor
Author
|
@Warashi I will work on it, thanks |
Fix gofmt formatting in application.go and canary_test.go, and remove unused namespace param in baselineDeployment test helper. Signed-off-by: majiayu000 <1835304752@qq.com>
Warashi
approved these changes
Mar 28, 2026
Member
Warashi
left a comment
Warashi
left a comment
There was a problem hiding this comment.
@majiayu000
Thank you. This PR is LGTM, so I'm going to merge.
BTW, do you have any idea to view the lint errors on the PR diffs view or as PR comments?
It's better to be able to view lint errors on PR, not the actions run logs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds
filter_mode: nofilterto thereviewdog/action-golangci-lintstep in the lint workflow. This makes reviewdog report all golangci-lint findings, not just those on lines added in the PR diff.Why we need it:
reviewdog's default
filter_modeisadded, which only reports issues on newly added lines. gofmt violations are reported at line 1 of the file, not at the actual offending line, so they get silently filtered out on PRs. The lint check passes on the PR, but then fails on master after merge.Which issue(s) this PR fixes:
Fixes #6621
Does this PR introduce a user-facing change?: